Bugzilla – Full Text Bug Listing |
Summary: | No ReceiveErrorModel in SimpleNetDevice | ||
---|---|---|---|
Product: | ns-3 | Reporter: | Craig Dowell <craigdo> |
Component: | network | Assignee: | Tom Henderson <tomh> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | mathieu.lacage, ns-bugs, tomh |
Priority: | P3 | ||
Version: | ns-3-dev | ||
Hardware: | All | ||
OS: | All |
Description
Craig Dowell
2008-11-17 22:48:53 EST
It has been decided to reduce priority and ask for comments on the list. (In reply to comment #0) > There presently is no ReceiveErrorModel attribute in Bridge, SimpleNetDevice, > or Wifi. I (tomh) would also propose to add this attribute to SimpleNetDevice, > at the very least. Is there a reason why not to include in all current > NetDevices? yes, such a feature is part of the "PHY" layer modeling. In wifi, this modeling is performed by the WifiPhy subclasses. The only such subclass (for now) is YansWifiPhy and this PHY model has nothing to do with a ReceiveErrorModel class. I would be fine with another WifiPhy subclass which performs packet error modeling based on a ReceiveErrorModel class. Another way to integrate this in the current YansWifiPhy model would be to implement a subclass of the ErrorRateModel which uses a ReceiveErrorModel to return either 0 or 1. Shall we not just close this bug as INVALID since I doubt anyone will ever do any work to make _every_ NetDevice subclass use an ErrorModel subclass. (In reply to comment #3) > Shall we not just close this bug as INVALID since I doubt anyone will ever do > any work to make _every_ NetDevice subclass use an ErrorModel subclass. I will take it. I want to add this to SimpleNetDevice. Changed title to reflect. changeset: c204cb0f18d8 |