Bug 1106 – Remove "CanvasLocation" dependencies in p2p helpers

Bug 1106 - Remove "CanvasLocation" dependencies in p2p helpers


Summary:	Remove "CanvasLocation" dependencies in p2p helpers

Status:	RESOLVED FIXED

Product:	ns-3
Classification:	Unclassified
Component:	helpers
Version:	pre-release
Hardware:	All All

Importance:	P5 enhancement
Assigned To:	John Abraham

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2011-04-19 09:13 EDT by John Abraham
Modified:	2011-04-22 15:45 EDT (History)
CC List:	3 users (show)

See Also:

Attachments
Removing CanvasLocation dependencies in NetAnim and examples/matrix-topology (23.85 KB, patch) 2011-04-19 19:40 EDT, John Abraham	Details \| Diff
Py bindings to be scanned later. Diff of changes in NetAnim and examples/matrix-topology (8.86 KB, patch) 2011-04-19 19:44 EDT, John Abraham	Details \| Diff
New patch removing canvas-location.cc and .h (10.30 KB, patch) 2011-04-21 11:59 EDT, John Abraham	Details \| Diff
dumbbell using pyViz after changes (21.07 KB, image/svg) 2011-04-21 12:02 EDT, John Abraham	Details
dumbbell before changes, using pyviz (22.02 KB, image/svg+xml) 2011-04-21 12:03 EDT, John Abraham	Details
Show Obsolete (2) Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description John Abraham 2011-04-19 09:13:26 EDT

The current p2p helpers depend on "CanvasLocation". However, as other modules such as wireless and pyviz use "MobilityModels" for node-placement, the "CanvasLocation" dependencies can be changed to a dependency on "MobilityModels".

Comment 1 John Abraham 2011-04-19 19:40:55 EDT

Created attachment 1085 [details]
Removing CanvasLocation dependencies in NetAnim and examples/matrix-topology

Comment 2 John Abraham 2011-04-19 19:44:13 EDT

Created attachment 1086 [details]
Py bindings to be scanned later. Diff of changes in NetAnim and examples/matrix-topology

Comment 3 Josh Pelkey 2011-04-21 09:34:15 EDT

This patch looks right to me. Did you test this out with net-anim to make sure the topologies still looked right? Also, you can try it in pyviz now too, and it should pick up on the mobility model and look the same as netanim now! Finally, is there any reason to keep CanvasLocation around any more?

Comment 4 John Abraham 2011-04-21 11:59:20 EDT

Created attachment 1088 [details]
New patch removing canvas-location.cc and .h

Comment 5 John Abraham 2011-04-21 12:02:18 EDT

Created attachment 1089 [details]
dumbbell using pyViz after changes

dumbbell using pyViz after changes

Comment 6 John Abraham 2011-04-21 12:03:28 EDT

Created attachment 1090 [details]
dumbbell before changes, using pyviz