Bug 1172 – Implement trivial XML output feature for Animation Interface

Bug 1172 - Implement trivial XML output feature for Animation Interface


Summary:	Implement trivial XML output feature for Animation Interface

Status:	RESOLVED FIXED

Product:	ns-3
Classification:	Unclassified
Component:	netanim
Version:	ns-3-dev
Hardware:	All All

Importance:	P5 enhancement
Assigned To:	John Abraham

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2011-05-26 14:57 EDT by John Abraham
Modified:	2016-01-05 22:30 EST (History)
CC List:	4 users (show)

See Also:

Attachments
incremental patch (21.74 KB, patch) 2011-06-09 15:56 EDT, John Abraham	Details \| Diff
first review (34.70 KB, patch) 2011-06-22 10:53 EDT, John Abraham	Details \| Diff
diff-07-02-2011 (27.99 KB, patch) 2011-07-02 22:14 EDT, John Abraham	Details \| Diff
with doxygen and check-style run (31.33 KB, patch) 2011-07-05 11:20 EDT, John Abraham	Details \| Diff
Show Obsolete (3) Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description John Abraham 2011-05-26 14:57:33 EDT

Implement trivial XML output feature for Animation Interface

Comment 1 John Abraham 2011-06-09 15:56:59 EDT

Created attachment 1161 [details]
incremental patch

Comment 2 John Abraham 2011-06-22 10:53:41 EDT

Created attachment 1168 [details]
first review

Comment 3 John Abraham 2011-07-02 22:14:33 EDT

Created attachment 1182 [details]
diff-07-02-2011

Comment 4 John Abraham 2011-07-05 11:20:10 EDT

Created attachment 1187 [details]
with doxygen and check-style run

Comment 5 Tom Henderson 2011-07-08 12:37:03 EDT

(In reply to comment #4)
> Created attachment 1187 [details]
> with doxygen and check-style run


For this type of patch, it is easier on reviewers (to leave in-line comments) to put it on Rietveld.

there appears to be some errors in the doxygen, can you check and fix those?

It seems like you are mixing two features in this patch:  XML output, and additional support for wireless animation for WiMax and WiFi.

Comment 6 John Abraham 2011-07-08 13:55:49 EDT

Wifi, and wimax modules are untouched. the Wifi and wimax references are related to the XML changes in netanim.Maybe I should have put a better title.

Can you paste the doxygen errors if you have it? I ran "test.py" and "doxygen-no-build" on ubuntu and did not spot errors. Although I see a few places where I should have added "\brief" to explain a bit more.


(In reply to comment #5)
> (In reply to comment #4)
> > Created attachment 1187 [details]
> > with doxygen and check-style run
> 
> 
> For this type of patch, it is easier on reviewers (to leave in-line comments)
> to put it on Rietveld.
> 
> there appears to be some errors in the doxygen, can you check and fix those?
> 
> It seems like you are mixing two features in this patch:  XML output, and
> additional support for wireless animation for WiMax and WiFi.

Comment 7 John Abraham 2016-01-05 22:30:46 EST

This had been resolved many years back with AnimationInterface working producing only XML formats