Bugzilla – Bug 1818
FlowMonitor needs IPv6 support
Last modified: 2014-04-21 05:37:21 EDT
Created attachment 1747 [details] patch Obviously IPv6 support is needed by FlowMonitor.
I scanned the patch and had one question and one comment. Why is this commented out? +// case Ipv6L3Protocol::DROP_FRAGMENT_TIMEOUT: +// myReason = DROP_FRAGMENT_TIMEOUT; +// NS_LOG_DEBUG ("DROP_FRAGMENT_TIMEOUT"); +// break; The comment is that it would be preferable to have some test code to exercise this, even though the original (IPv4 case) lacks test code coverage.
Created attachment 1767 [details] new manual This is the FlowMonitor updated manual. Gustavo already checked it.
Something I missed before: there are a few unanswered questions in the text: "What kind of data does the model generate? What are the key trace sources? What kind of logging output can be enabled?" Some copy-pasted template?
(In reply to Tom Henderson from comment #1) > I scanned the patch and had one question and one comment. > > Why is this commented out? > +// case Ipv6L3Protocol::DROP_FRAGMENT_TIMEOUT: > +// myReason = DROP_FRAGMENT_TIMEOUT; > +// NS_LOG_DEBUG ("DROP_FRAGMENT_TIMEOUT"); > +// break; The answer is: it's [missing feature] in IPv6. When a packet is lost due to fragment timeouts, the drop trace is not called. I'll fix it (in another bug). before applying this one, of course. > The comment is that it would be preferable to have some test code to > exercise this, even though the original (IPv4 case) lacks test code coverage. Yeah… it would :P As a matter of fact, FlowMonitor lacks tests more or less for everything. However, if you don't mind, I'd fix that later on.
(In reply to Gustavo J. A. M. Carneiro from comment #3) > Something I missed before: there are a few unanswered questions in the text: > > "What kind of data does the model generate? What are the key trace > sources? What kind of logging output can be enabled?" > > Some copy-pasted template? Yes, I forgot those sections. I'll add them.
Created attachment 1769 [details] new patch
Created attachment 1771 [details] updated manual New manual version. Clarified some points, added an XML example and removed unused sections.
Comment on attachment 1771 [details] updated manual Moved to bug #1802
pushed in changeset 10692:bdf59f5ace93