Bug 2016 – Radvd do not consider the SendAdvert option and don't reply to RS

Bug 2016 - Radvd do not consider the SendAdvert option and don't reply to RS


Summary:	Radvd do not consider the SendAdvert option and don't reply to RS

Status:	RESOLVED FIXED

Product:	ns-3
Classification:	Unclassified
Component:	applications
Version:	ns-3-dev
Hardware:	All All

Importance:	P5 normal
Assigned To:	George Riley

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2014-11-09 17:00 EST by Tommaso Pecorella
Modified:	2014-11-18 18:17 EST (History)
CC List:	2 users (show)

See Also:

Attachments
patch (931 bytes, patch) 2014-11-09 17:02 EST, Tommaso Pecorella	Details \| Diff
patch (9.87 KB, patch) 2014-11-14 04:43 EST, Tommaso Pecorella	Details \| Diff
new patch (30.15 KB, patch) 2014-11-16 12:16 EST, Tommaso Pecorella	Details \| Diff
Show Obsolete (2) Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Tommaso Pecorella 2014-11-09 17:00:49 EST

Radvd simply ignores the fact that SendAdvert is turned off.
The attached patch fixes this misbehaviour.

Comment 1 Tommaso Pecorella 2014-11-09 17:02:00 EST

Created attachment 1916 [details]
patch

Comment 2 Tommaso Pecorella 2014-11-14 04:43:58 EST

Created attachment 1917 [details]
patch

It turns out that raided had more bugs than expected.
1) RS are not correctly received and parsed
2) when an RS parsed, the reply is sent on all the interfaces, causing a NS flood on the "wrong" interfaces

This patch fixes all the issues.
Moreover, it updates the raided example to show how to disable automatic RA on one of the two interfaces.

Comment 3 Tommaso Pecorella 2014-11-16 12:16:07 EST

Created attachment 1921 [details]
new patch

Better fix, following more strictly what's suggested in RFC 4861

Comment 4 Tom Henderson 2014-11-17 19:59:31 EST

please merge when ready (p.s. minor nit:  you still have magic numbers instead of constants in your constructor initializers)

Comment 5 Tommaso Pecorella 2014-11-18 18:17:54 EST

changeset:   11062:91a7bee99048

The magic numbers are the ones from RFC 4861, and they should be converted into Attributes (maybe). I'll do it in the next patch if there is interest in tweaking RADVD params.