Bug 2125 – Subclasses should chain up to their base class NotifyNewAggregate() method

Bug 2125 - Subclasses should chain up to their base class NotifyNewAggregate() method


Summary:	Subclasses should chain up to their base class NotifyNewAggregate() method

Status:	RESOLVED FIXED

Product:	ns-3
Classification:	Unclassified
Component:	general
Version:	ns-3-dev
Hardware:	All All

Importance:	P5 minor
Assigned To:	ns-bugs

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2015-05-27 19:26 EDT by nlmills
Modified:	2015-06-25 00:51 EDT (History)
CC List:	2 users (show)

See Also:

Attachments
Proposed patch (3.12 KB, patch) 2015-05-27 19:33 EDT, nlmills	Details \| Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description nlmills 2015-05-27 19:26:51 EDT

Classes that override Object::NotifyNewAggregate() "must chain up to their base class NotifyNewAggregate() method" according to the documentation. However, examples in the current code always invoke Object::NotifyNewAggregate() regardless of the actual base class.

Comment 1 nlmills 2015-05-27 19:33:17 EDT

Created attachment 2048 [details]
Proposed patch

Patch against d118c95b966c952258dc1db67832dfa5c6a44685

Comment 2 Tommaso Pecorella 2015-05-28 05:59:33 EDT

+1, even if it's mostly a stylistic problem.

Comment 3 Tom Henderson 2015-06-11 13:10:20 EDT

Yes, I put this on the ns-3.24 schedule.

Comment 4 Tom Henderson 2015-06-25 00:51:53 EDT

committed in changeset 11463:60d4486a863a