Bug 2146 – The patch for WAVE channel coordination and WAVE example reported by Tiago Cerqueira

Bug 2146 - The patch for WAVE channel coordination and WAVE example reported by Tiago Cerqueira


Summary:	The patch for WAVE channel coordination and WAVE example reported by Tiago Ce...

Status:	RESOLVED FIXED

Product:	ns-3
Classification:	Unclassified
Component:	wave module
Version:	pre-release
Hardware:	PC Linux

Importance:	P5 enhancement
Assigned To:	ns-bugs

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2015-07-01 10:46 EDT by Junling Bu
Modified:	2015-08-21 15:00 EDT (History)
CC List:	1 user (show)

See Also:

Attachments
The patch for WAVE channel coordination and WAVE example reported by Tiago Cerqueira (5.49 KB, patch) 2015-07-01 10:46 EDT, Junling Bu	Details \| Diff
The new patch which removes LOG_UNCOND (4.29 KB, patch) 2015-08-07 12:20 EDT, Junling Bu	Details \| Diff
Show Obsolete (1) Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Junling Bu 2015-07-01 10:46:18 EDT

Created attachment 2075 [details]
The patch for WAVE channel coordination and WAVE example reported by Tiago Cerqueira

Hi, 

Tiago Cerqueira  has reported some issues about  WAVE channel coordination and WAVE example,
in the mailing list https://mail.google.com/mail/u/0/?tab=wm#inbox/14e32cdbd96b1e3f
So I debug and create this patch.
I think I fix his problems.

Thanks.

Junling

Comment 1 Tom Henderson 2015-07-29 18:28:26 EDT

Does this patch solve the synchronization issue that Tiago pointed out on the list?  I don't see any delay randomization added to it.

Also, I prefer to avoid NS_LOG_UNCOND() and keep the std::cout.  NS_LOG statements disappear in optimized builds.

Comment 2 Junling Bu 2015-08-07 12:20:18 EDT

Created attachment 2112 [details]
The new patch which removes LOG_UNCOND

Comment 3 Junling Bu 2015-08-07 12:23:28 EDT

(In reply to Tom Henderson from comment #1)
> Does this patch solve the synchronization issue that Tiago pointed out on
> the list?  I don't see any delay randomization added to it.
> 
> Also, I prefer to avoid NS_LOG_UNCOND() and keep the std::cout.  NS_LOG
> statements disappear in optimized builds.

Hi Tom,

The patch fixed the problem reported by Tiago, which is not caused by synchronization actually. And he has confirmed that his example can run as supposed.

In this new patch, I follow your suggestion to not use ND_LOG_UNCOND.

Comment 4 Tom Henderson 2015-08-21 15:00:51 EDT

pushed in changeset 11608:79f3e06b9420