Bugzilla – Bug 2147
patch set for TCP revisions
Last modified: 2015-07-13 23:39:01 EDT
Created attachment 2078 [details] tar file of eighteen patches As discussed on the developers list and this wiki page: https://www.nsnam.org/wiki/GSOC2015TCPTest#Midterm_review The following patches are included in the tar file. 0001-Removed-Send-public-SendPacket.patch 0002-AddSocket-and-RemoveSocket-added-to-TcpL4Protocol.patch 0003-TcpSocketBase-now-uses-only-public-API-from-TcpL4Pro.patch 0004-Polish-tcp-l4-protocol-from-useless-header.patch 0005-Documentation-improvements-on-TcpL4Protocol.patch 0006-BUG-2132-Fixed-RST-packet-formatting.patch 0007-Duplicated-code-removed-from-Receive-in-TcpL4Protoco.patch 0008-Const-correctness-enforced.patch 0009-Checked-style-on-TcpL4Protocol.patch 0010-Addressed-comment-in-CodeReview.patch 0011-DoForwardUp-behavior-unified-for-IPv4-and-IPv6.patch 0012-TcpHeader-can-be-printed-in-NS_LOG-messages.patch 0013-TCP-flags-are-now-printed-using-string-instead-of-nu.patch 0014-API-for-deprecating-attributes-and-trace-sources-add.patch 0015-Moved-cWnd-and-ssThresh-inside-TcpSocketBase.patch 0016-Initialize-cWnd-and-ssTh-in-TcpSocketBase.patch 0017-Window-is-now-managed-inside-TcpSocketBase.patch 0018-Documented-TCP-states-moved-enum-inside-TcpSocket.patch
patch 0014 has been moved to a separate issue since it deals with a core change https://www.nsnam.org/bugzilla/show_bug.cgi?id=2149
+1 from me, minus the patch about trace sources where I prefer Peter's approach. Patch for each particular change made this easier to review, so we should definitely do that more often. On the code level, I really like how Natale unified DoForwardUp and CongestionWindow stuff and de-duplicated the code.
Seventeen of the eighteen patches were pushed on 13 July 2015; the eighteenth (number 0014 in the list) on deprecated attributes was held back and is now tracked in bug 2049.