Bug 250 - Tcp breaks if you set the delackcount > 2
Tcp breaks if you set the delackcount > 2
Product: ns-3
Classification: Unclassified
Component: internet
All All
: P1 normal
Assigned To: Rajib Bhattacharjea
Depends on:
  Show dependency treegraph
Reported: 2008-07-09 14:27 EDT by Rajib Bhattacharjea
Modified: 2008-12-06 03:13 EST (History)
2 users (show)

See Also:

simple fix (547 bytes, patch)
2008-12-01 10:42 EST, Rajib Bhattacharjea
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rajib Bhattacharjea 2008-07-09 14:27:13 EDT
If you try to tell TCP to ack each third(4th, 5th, etc) packet instead of each second one, the code has a logical error preventing its correct operation.  This is TcpSocket attribute DelAckCount.

Offending code is lines 1129-1139 in http://code.nsnam.org/ns-3-dev/file/266c6a334762/src/internet-stack/tcp-socket-impl.cc
Comment 1 Rajib Bhattacharjea 2008-12-01 10:42:17 EST
Created attachment 321 [details]
simple fix

Test case:
./waf --run="tcp-large-transfer --ns3::TcpSocket::DelAckCount=3"

Appears to work as proposed.
Comment 2 Rajib Bhattacharjea 2008-12-01 10:47:12 EST
Patch looks good, reassigning to release manager.
Comment 3 Rajib Bhattacharjea 2008-12-03 11:20:24 EST
Reassigned to myself.