Bug 2936 – gcc-8 (Fedora 28) and GTK+

Bug 2936 - gcc-8 (Fedora 28) and GTK+


Summary:	gcc-8 (Fedora 28) and GTK+

Status:	RESOLVED FIXED

Product:	ns-3
Classification:	Unclassified
Component:	config-store
Version:	ns-3.28
Hardware:	All All

Importance:	P3 normal
Assigned To:	Tom Henderson

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2018-06-21 19:51 EDT by Tom Henderson
Modified:	2018-08-07 00:56 EDT (History)
CC List:	0 users

See Also:	2938

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Tom Henderson 2018-06-21 19:51:11 EDT

Compiling ns-3 on Fedora 28 with GTK+ installed yields the following errors due to -Wparentheses:

/usr/include/gtk-2.0/gtk/gtkfilechooserbutton.h:59:8: error: unnecessary parentheses in declaration of ‘__gtk_reserved1’ [-Werror=parentheses]
   void (*__gtk_reserved1);

(and other similar ones)

this is an upstream GTK+ bug:

https://bugzilla.redhat.com/show_bug.cgi?id=1576301
https://gitlab.gnome.org/GNOME/gtk/issues/1142

According to the latter, this is fixed in the gtk-3-22 branch.

In the meantime, until newer versions of GTK+ are available, we can add some support in wscript to enable -Wno-parentheses under these conditions.

Comment 1 Tom Henderson 2018-07-22 17:28:00 EDT

The --disable-werror patch for bug 2938 is one possible workaround, but I will create also a patch that does not require disabling Werror globally.  In progress...

Comment 2 Tom Henderson 2018-08-07 00:53:59 EDT

fixed in changeset 13722:6fb964c157bd

Comment 3 Tom Henderson 2018-08-07 00:56:38 EDT

(In reply to Tom Henderson from comment #2)
> fixed in changeset 13722:6fb964c157bd

correction:  changeset 13725:2448e59305bd