Bug 874 - wrong modulation type is selected in the forwardBurst method
wrong modulation type is selected in the forwardBurst method
Product: ns-3
Classification: Unclassified
Component: wimax
All All
: P3 normal
Assigned To: Mohamed Amine ISMAIL
Depends on:
  Show dependency treegraph
Reported: 2010-04-13 09:09 EDT by Mohamed Amine ISMAIL
Modified: 2010-08-08 15:25 EDT (History)
4 users (show)

See Also:


Note You need to log in before you can comment on or make changes to this bug.
Description Mohamed Amine ISMAIL 2010-04-13 09:09:19 EDT
The modulation type is not correctly set in the method  forwardBurst.
in fact the following lines in bs-net-device.cc 

959 if (m_serviceFlowManager->GetServiceFlow (cid)->GetIsMulticast () == true)
960   {
961     modulationType = m_serviceFlowManager->GetServiceFlow (cid)->GetModulation ();
962   }

should be changed to:

961   modulationType = m_serviceFlowManager->GetServiceFlow (cid)->GetModulation ();

lines 959, 960, and 962 should be removed
Comment 1 Mohamed Amine ISMAIL 2010-06-08 04:58:35 EDT
Comment 2 Josh Pelkey 2010-07-16 11:23:41 EDT
Is this one resolved?  I looked at the file and the change you suggested, but it looked a bit different now.
Comment 3 Tom Henderson 2010-07-18 23:30:35 EDT
Amine, please review and close this if it is resolved.
Comment 4 Flavio Kubota 2010-08-08 15:25:33 EDT
The suggested patch was applied.