Bug 876 – Tcp socket does not handle ShutdownRecv correctly

Bug 876 - Tcp socket does not handle ShutdownRecv correctly


Summary:	Tcp socket does not handle ShutdownRecv correctly

Status:	RESOLVED FIXED

Product:	ns-3
Classification:	Unclassified
Component:	internet
Version:	ns-3-dev
Hardware:	All All

Importance:	P5 normal
Assigned To:	Josh Pelkey

URL:
Keywords:

Depends on:
Blocks:	833
	Show dependency tree / graph

Reported:	2010-04-14 13:41 EDT by Josh Pelkey
Modified:	2010-04-14 16:59 EDT (History)
CC List:	2 users (show)

See Also:

Attachments
simple fix (1.44 KB, patch) 2010-04-14 14:25 EDT, Josh Pelkey	Details \| Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Josh Pelkey 2010-04-14 13:41:27 EDT

Discovered from bug 818, calling ShutdownRecv when using tcp-socket causes problems since TcpSocketImpl::ForwardUp simply returns before processing the event or action.  So state is not updated and packets are not processed after ShutdownRecv.

Comment 1 Josh Pelkey 2010-04-14 14:25:30 EDT

Created attachment 831 [details]
simple fix

The simplest fix.  Remove check for shutdownRecv in ForwardUp and just check right before each call to NotifyDataRecv.

Comment 2 Tom Henderson 2010-04-14 16:25:57 EDT

(In reply to comment #1)
> Created an attachment (id=831) [details]
> simple fix
> 
> The simplest fix.  Remove check for shutdownRecv in ForwardUp and just check
> right before each call to NotifyDataRecv.

Looks like the right thing to do, so +1 from me to commit so that you can unblock the other patches too and we can start to test this more.

Comment 3 Josh Pelkey 2010-04-14 16:59:03 EDT

changeset cc5b5294031f