Bug 899 - EmuNetDevice::SetPromiscReceiveCallback not implemented
EmuNetDevice::SetPromiscReceiveCallback not implemented
Status: RESOLVED FIXED
Product: ns-3
Classification: Unclassified
Component: devices
ns-3-dev
All All
: P5 major
Assigned To: ns-bugs
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-04-28 08:19 EDT by Gustavo J. A. M. Carneiro
Modified: 2010-04-28 10:19 EDT (History)
1 user (show)

See Also:


Attachments
the patch (422 bytes, patch)
2010-04-28 09:03 EDT, Gustavo J. A. M. Carneiro
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gustavo J. A. M. Carneiro 2010-04-28 08:19:47 EDT
EmuNetDevice::SetPromiscReceiveCallback is not implemented:

void
EmuNetDevice::SetPromiscReceiveCallback (PromiscReceiveCallback cb)
{
  NS_FATAL_ERROR ("EmuNetDevice::SetPromiscReceiveCallback(): Not implemented");
}

The correct implementation is trivial, as ForwardUp already takes care to use m_promiscRxCallback if set.  Change to:

void
EmuNetDevice::SetPromiscReceiveCallback (PromiscReceiveCallback cb)
{
  m_promiscRxCallback = cb;
}
Comment 1 Gustavo J. A. M. Carneiro 2010-04-28 09:03:04 EDT
Created attachment 851 [details]
the patch
Comment 2 Josh Pelkey 2010-04-28 10:19:21 EDT
changeset ba09ab600218