Bug 925 – Various IPv6 cc files trigger deprecated warning

Bug 925 - Various IPv6 cc files trigger deprecated warning


Summary:	Various IPv6 cc files trigger deprecated warning

Status:	RESOLVED FIXED

Product:	ns-3
Classification:	Unclassified
Component:	internet
Version:	ns-3-dev
Hardware:	All All

Importance:	P5 normal
Assigned To:	ns-bugs

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2010-05-28 00:43 EDT by Quincy Tse
Modified:	2010-08-11 00:31 EDT (History)
CC List:	1 user (show)

See Also:

Attachments
Proposed patch. (2.77 KB, patch) 2010-05-28 00:43 EDT, Quincy Tse	Details \| Diff
Proposed patch. (9.64 KB, patch) 2010-05-28 01:14 EDT, Quincy Tse	Details \| Diff
Show Obsolete (1) Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Quincy Tse 2010-05-28 00:43:37 EDT

Created attachment 895 [details]
Proposed patch.

icmpv6-header.cc uses the deprecated Packet::PeekData ().

Comment 1 Quincy Tse 2010-05-28 01:14:24 EDT

Updated to include all IPv6 files that triggers the deprecation warning.

Comment 2 Quincy Tse 2010-05-28 01:14:56 EDT

Created attachment 896 [details]
Proposed patch.

Comment 3 Quincy Tse 2010-05-28 01:49:08 EDT

I'll concede that the variable names in the patch are quite ugly "firstOctet" I think I can replace some of them with "type", but I'm really not certain about the layout of IPv6. There are also places where (I think) the value of the first octet had been copied multiple times (every time I see PeekData ()) - I don't know whether the value might be changed, so I kept them there just in case.

Comment 4 Josh Pelkey 2010-08-11 00:31:45 EDT

changeset: 487146fc889e